Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review #4

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Code review #4

merged 4 commits into from
Apr 25, 2024

Conversation

iglauss
Copy link
Contributor

@iglauss iglauss commented Apr 25, 2024 •
edited
Loading

Source code review: some updates

@iglauss iglauss requested a review from a team as a code owner April 25, 2024 10:17
zsigmas
zsigmas approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@zsigmas zsigmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on my side, small suggestion for a typo

DESCRIPTION Outdated
@@ -10,10 +10,10 @@ Authors@R:
person('Luis', 'Morís Fernández', email = '[email protected]', role = c('aut')),
person('Jessica', 'Knizia', email = '[email protected]', role = c('ctb'))
)
Description: DaVinci’s dv.listings module displays a data listing of different dataset domains in tabular form.
Description: DaVinci’s dv.listings package provides a modules to display different dataset domains as listings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Description: DaVinci’s dv.listings package provides a modules to display different dataset domains as listings.
Description: DaVinci’s dv.listings package provides modules to display different dataset domains as listings.

@zsigmas
Copy link
Contributor

zsigmas commented Apr 25, 2024

Also docs complains about:

-- Building function reference ------------------------------------------------- Error: ! in callr subprocess. Caused by error in "check_missing_topics(rows, pkg)": ! All topics must be included in reference index ✖ Missing topics: listings_UI, mock_simple_listing_mm ℹ Either add to _pkgdown.yml or use @keywords internal

@iglauss
Copy link
Contributor Author

iglauss commented Apr 25, 2024 •
edited
Loading

Thanks @zsigmas for reviewing! I fixed the typo and solved the issue with _pkgdown.yml :)

@iglauss iglauss merged commit e844360 into main Apr 25, 2024
6 checks passed
@iglauss iglauss deleted the code-review branch April 25, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsigmas zsigmas zsigmas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iglauss @zsigmas